Updated form/* articles to Symfony 4 #8755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
force-pushed
the
update_forms
branch
from
b969501 to
82afb31
Compare
yceruto
reviewed
Nov 26, 2017
form/create_form_type_extension.rst
Outdated
| @@ -233,7 +236,7 @@ Specifically, you need to override the ``file_widget`` block: | |||
|
|
|||
| .. code-block:: html+php | |||
|
|
|||
| <!-- app/Resources/file_widget.html.php --> | |||
| <!-- templates/form/file_widget.html.php --> | |||
There was a problem hiding this comment.
Should be src/Resources/... for PHP templating engine, right?
There was a problem hiding this comment.
I'm not sure ... but I've reverted my changes. In any case, we'll remove all PHP template examples very soon.
forms.rst
Outdated
| @@ -338,7 +338,7 @@ object. | |||
|
|
|||
| .. code-block:: yaml | |||
|
|
|||
| # src/Resources/config/validation.yml | |||
| # src/Resources/config/validation.yaml | |||
form/form_collections.rst
Outdated
| @@ -510,7 +510,7 @@ you will learn about next!). | |||
|
|
|||
| .. code-block:: yaml | |||
|
|
|||
| # src/Resources/config/doctrine/Task.orm.yml | |||
| # src/Resources/config/doctrine/Task.orm.yaml | |||
There was a problem hiding this comment.
I'm not sure if yaml ext is already supported for Doctrine :/ https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mapping/Driver/SimplifiedYamlDriver.php#L33
There was a problem hiding this comment.
That's sad. Reverted.
|
@yceruto thanks for your review! |
weaverryan
added a commit
that referenced
this pull request
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.