Separate dev dependencies from application dependencies #8856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react react-dom and prop-types shouldn't be dev dependencies
rzilin
approved these changes
Jan 26, 2018
javiereguiluz
approved these changes
Jan 29, 2018
There was a problem hiding this comment.
I've looked into React repos and this seems the right thing to do. It's better explained in issues like this one: facebook/create-react-app#1764
|
Thanks Eric. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 29, 2018
…Tucker-Eric) This PR was merged into the 4.0 branch. Discussion ---------- Separate dev dependencies from application dependencies react react-dom and prop-types shouldn't be dev dependencies Commits ------- d1f32b3 Separate dev dependencies from application dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react react-dom and prop-types shouldn't be dev dependencies