Skip to content

Improved the Process component documentation #8881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2018
Merged

Improved the Process component documentation #8881

merged 1 commit into from
Jan 2, 2018

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Dec 15, 2017 •
edited
Loading

This is related to #8879 and, if merged, it must be merged after it.

TomasVotruba
TomasVotruba reviewed Dec 15, 2017
View reviewed changes
Copy link

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@xabbuh
Copy link
Member

xabbuh commented Dec 15, 2017

I think we should merge this PR and #8879 into the 3.4 branch.

@TomasVotruba TomasVotruba mentioned this pull request Dec 17, 2017
Merged
@TomasVotruba
Copy link

I've added Rector for this: rectorphp/rector#188

Could you confirm there I got it right? Also more cases would be great

@javiereguiluz javiereguiluz mentioned this pull request Dec 28, 2017
Closed
@javiereguiluz
Copy link
Member Author

@xabbuh I'm sorry but I'm merging this into 4.0 because the related #8879 PR was merged into 4.0 too instead of 3.4.

@javiereguiluz javiereguiluz merged commit 6928793 into symfony:4.0 Jan 2, 2018
javiereguiluz added a commit that referenced this pull request Jan 2, 2018
@javiereguiluz
minor #8881 Improved the Process component documentation (javiereguiluz)
0844c1c 
This PR was merged into the 4.0 branch.

Discussion
----------

Improved the Process component documentation

This is related to #8879 and, if merged, it must be merged after it.

Commits
-------

6928793 Improved the Process component documentation
@xabbuh xabbuh added this to the 4.0 milestone Jan 2, 2018
@TomasVotruba
Copy link

Thanks @javiereguiluz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

Assignees
No one assigned
Labels
Process Status: Needs Review
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @xabbuh @TomasVotruba @carsonbot