Skip to content

Fix not existing secret parameter #8926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2017
Merged

Fix not existing secret parameter #8926

merged 1 commit into from
Dec 31, 2017

Conversation

pyrech
Copy link
Contributor

@pyrech pyrech commented Dec 23, 2017

Not sure about this one but the secret parameter does not seem to exist on a fresh Symfony install

@xabbuh
Copy link
Member

xabbuh commented Dec 26, 2017

That's weird. The parameter should be set thanks to the recipe for the FrameworkBundle: https://github.com/symfony/recipes/blob/master/symfony/framework-bundle/3.3/config/packages/framework.yaml#L2

@pyrech
Copy link
Contributor Author

pyrech commented Dec 27, 2017

I'm not sure I understand what you mean. The configuration you linked to only show the secret configuration of the framework bundle, that does not mean a secret parameter will be available in the DIC. Am I missing something?

@wouterj
Copy link
Member

wouterj commented Dec 31, 2017 •
edited
Loading

I think this PR is correct. We should use kernel.secret or %env(APP_SECRET)%. Previously, instead of .env, we used parameters.yml with this secret parameter. Since Symfony Flex, this is now changed to the environment.

I think kernel.secret would be the best option.

👍

@wouterj wouterj self-requested a review December 31, 2017 12:25
@xabbuh
Copy link
Member

xabbuh commented Dec 31, 2017

@pyrech Sorry, I confused myself. You are absolutely right with the proposed changes. 👍

@xabbuh
Copy link
Member

xabbuh commented Dec 31, 2017

Thank you @pyrech.

@xabbuh xabbuh merged commit b7ea63a into symfony:4.0 Dec 31, 2017
xabbuh added a commit that referenced this pull request Dec 31, 2017
@xabbuh
minor #8926 Fix not existing secret parameter (pyrech)
967ee2a 
This PR was merged into the 4.0 branch.

Discussion
----------

Fix not existing secret parameter

Not sure about this one but the `secret` parameter does not seem to exist on a fresh Symfony install

Commits
-------

b7ea63a Fix not existing secret parameter
@pyrech pyrech deleted the patch-1 branch January 2, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pyrech @xabbuh @wouterj @carsonbot