Skip to content

Clean up #8948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Clean up #8948

wants to merge 2 commits into from

Conversation

carusogabriel
Copy link
Contributor

Following #8947, suggested by @xabbuh

@carusogabriel
Trailing whitespaces
a21f1d8 
Signed-off-by: Gabriel Caruso <[email protected]>
@carusogabriel
Remove extra lines
8f3bf4c 
Signed-off-by: Gabriel Caruso <[email protected]>
wouterj
wouterj approved these changes Dec 31, 2017
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status: reviewed

Thanks a lot for your work! Enjoy new year! 😉

@xabbuh xabbuh added this to the 4.0 milestone Jan 1, 2018
xabbuh added a commit that referenced this pull request Jan 1, 2018
@xabbuh
minor #8948 Clean up (carusogabriel)
936d239 
This PR was squashed before being merged into the 3.4 branch (closes #8948).

Discussion
----------

Clean up

Following #8947, suggested by @xabbuh

Commits
-------

509e05f Clean up
@xabbuh
Copy link
Member

xabbuh commented Jan 1, 2018

Thanks and a happy new year @carusogabriel! The 4.0 branch is now ready too. :)

@xabbuh xabbuh closed this Jan 1, 2018
@carusogabriel carusogabriel deleted the clean-up branch January 1, 2018 14:52
@carusogabriel
Copy link
Contributor Author

@xabbuh @wouterj Happy New Year guys. PRing in 4.0 in a minute 🎉

@carusogabriel carusogabriel mentioned this pull request Jan 1, 2018
Closed
xabbuh added a commit that referenced this pull request Jan 1, 2018
@xabbuh
minor #8953 Clean up (carusogabriel)
70d0f78 
This PR was squashed before being merged into the 4.0 branch (closes #8953).

Discussion
----------

Clean up

Following #8948, suggested by @xabbuh

Commits
-------

ce10e67 Clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@carusogabriel @xabbuh @wouterj @carsonbot