Add environment variables #8974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jan 9, 2018
There was a problem hiding this comment.
@ProfM2 I like this, thanks for contributing it. However, using env vars is optional (even in Symfony 4), so I reworded your config to mention that it's optional. Thanks!
|
There are more virtual host config examples on this page. Should we update them all? And what about the Nginx example config? |
|
I wouldn't add them in the other Apache examples ... but if someone knows nginx, please tell us which is the equivalent config to add. Thanks! |
# optionally set the value of the environment variables used in the application
# fastcgi_param APP_ENV prod;
# fastcgi_param APP_SECRET <app-secret-id>;
# fastcgi_param DATABASE_URL "mysql://db_user:db_pass@host:3306/db_name";That should do the trick. |
|
@ProfM2 thank you for helping us improving this. It was a nice first contribution to Symfony Docs. Congrats! |
javiereguiluz
added a commit
that referenced
this pull request
Jan 10, 2018
This PR was merged into the 4.0 branch. Discussion ---------- Add environment variables Add server environment variables, specifically for production use. Commits ------- ab2c135 Added the env vars in the nginx config too 45c2939 Commented the env vars and mentioned that they are optional f64bc6b Add environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add server environment variables, specifically for production use.