Handler formatter example was using wrong defined service #9000
Conversation
|
This looks OK ... but Monolog was always too confusing to me, so I'll wait for other reviews before merging. Also, if this is the correct change, we should update the XML and PHP config below too. Thanks! |
| @@ -71,7 +71,7 @@ using a processor. | |||
| type: stream | |||
| path: '%kernel.logs_dir%/%kernel.environment%.log' | |||
| level: debug | |||
| formatter: app.logger.session_request_processor | |||
| formatter: monolog.formatter.session_request | |||
There was a problem hiding this comment.
This change looks correct to me. Can you also update the other configuration formats? They seem to have the same incorrect value at the formatter option.
There was a problem hiding this comment.
@iltar no problem, I've updated the other configuration formats
The service class passed to the formatter in the example handler was using the processor service instead of the formatter service. It should instead use `monolog.formatter.session_request`, otherwise monolog complains that the class does not implement interface `Monolog\Formatter\FormatterInterface`.
|
@gregsomers thanks for fixing this! We've merged it on 2.7 branch, which is the oldest maintained branch that contains the bug and we'll "merge it up" on the other branches. GitHub may make it look as closed instead of merged ... but it's merged. Thanks! |
… (gregsomers) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #9000). Discussion ---------- Handler formatter example was using wrong defined service The service class passed to the formatter in the example handler was using the processor service instead of the formatter service. It should instead use `monolog.formatter.session_request`, otherwise monolog complains that the class does not implement interface `Monolog\Formatter\FormatterInterface`. Commits ------- 447844a Handler formatter example was using wrong defined service
The service class passed to the formatter in the example handler was using the processor service instead of the formatter service. It should instead use
monolog.formatter.session_request, otherwise monolog complains that the class does not implement interfaceMonolog\Formatter\FormatterInterface.