Skip to content

Update routing.rst #9051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Update routing.rst #9051

merged 1 commit into from
Jan 13, 2018

Conversation

rickwest
Copy link
Contributor

Add trailing comma after last item of multiline array as suggested by #8325

Add trailing comma after last item of multiline array as suggested by #8325
@javiereguiluz
Copy link
Member

@rickwest thanks for fixing this. Before making more changes like this: yesterday I chatted in the Symfony Slack with @DylanDelobel and he's going to fix all examples in the docs. We talked about coordinating ourselves because it's important to start in the lowest branch and then merge things quickly so he can go the next branch.

@javiereguiluz
Copy link
Member

javiereguiluz commented Jan 13, 2018

It's merged. Thanks! And congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit b78ae51 into symfony:4.0 Jan 13, 2018
javiereguiluz added a commit that referenced this pull request Jan 13, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Update routing.rst

Add trailing comma after last item of multiline array as suggested by #8325

Commits
-------

b78ae51 Update routing.rst
xabbuh pushed a commit that referenced this pull request Jan 15, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Update routing.rst

Add trailing comma after last item of multiline array as suggested by #8325

Commits
-------

b78ae51 Update routing.rst
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 17, 2018
* 2.7:
  Fixed the default value for toolbar configuration
  Close the tag
  minor symfony#9051 Update routing.rst (rickwest)
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 17, 2018
* 2.8:
  Fixed the default value for toolbar configuration
  Close the tag
  minor symfony#9051 Update routing.rst (rickwest)
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 17, 2018
* 3.3:
  Fixed the default value for toolbar configuration
  Close the tag
  minor symfony#9051 Update routing.rst (rickwest)
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 17, 2018
* 3.4:
  Fixed the default value for toolbar configuration
  Close the tag
  minor symfony#9051 Update routing.rst (rickwest)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants