preUpdate Event Listener On Uploaded Imagery #9079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed a scenario (a bit of an edge case when uploading imagery). If you have an entity (say a brochure) but you can give it a title and an image and the image title can be updated without the image being updated (the file type is not an UploadedFile but a File on save it'll persist the full file path instead of the desired filename. The above is a safety measure to ensure the above.
matt9mg
changed the title
Simperfit
reviewed
Jan 19, 2018
controller/upload_file.rst
Outdated
| @@ -362,6 +363,10 @@ automatically upload the file when persisting the entity:: | |||
| if ($file instanceof UploadedFile) { | |||
| $fileName = $this->uploader->upload($file); | |||
| $entity->setBrochure($fileName); | |||
| } elseif($file instanceof File) { | |||
There was a problem hiding this comment.
it should be :
elseif ($file instanceof File) {
There was a problem hiding this comment.
Thank you @Simperfit updated!
controller/upload_file.rst
Outdated
| } elseif ($file instanceof File) { | ||
| // prevents the full file path being saved on updates | ||
| // as the path is set on the postLoad listener | ||
| $entity->setBrocure($file->getFilename()); |
There was a problem hiding this comment.
Typo: setBrocure -> setBrochure
There was a problem hiding this comment.
@javiereguiluz thank you for the feedback :)
rzilin
approved these changes
Feb 17, 2018
|
cough 😊 |
|
@matt9mg sorry for not having reviewed this sooner. Let's ping @vudaltsov because he recently reviewed another change proposal related to file upload. Thanks! |
HeahDude
approved these changes
Jun 28, 2018
| } elseif ($file instanceof File) { | ||
| // prevents the full file path being saved on updates | ||
| // as the path is set on the postLoad listener | ||
| $entity->setBrochure($file->getFilename()); |
There was a problem hiding this comment.
Yes this prevents a cast to string.
9 tasks
|
Thank you @matt9mg. |
xabbuh
added a commit
that referenced
this pull request
Aug 7, 2018
This PR was submitted for the 4.0 branch but it was squashed and merged into the 2.8 branch instead (closes #9079). Discussion ---------- preUpdate Event Listener On Uploaded Imagery I've noticed a scenario (a bit of an edge case when uploading imagery). If you have an entity (say a brochure) but you can give it a title and an image and the image title can be updated without the image being updated (the file type is not an UploadedFile but a File on save it'll persist the full file path instead of the desired filename. The above is a safety measure to ensure the above. Commits ------- a4cc43a preUpdate Event Listener On Uploaded Imagery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a scenario (a bit of an edge case when uploading imagery).
If you have an entity (say a brochure) but you can give it a title and an image and the image title can be updated without the image being updated (the file type is not an UploadedFile but a File on save it'll persist the full file path instead of the desired filename. The above is a safety measure to ensure the above.