Skip to content

Update doctrine.rst #9141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update doctrine.rst #9141

wants to merge 1 commit into from

Conversation

tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Jan 26, 2018

my doctrine.yml had a charset: utf8mb4 but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the database

path: ~
memory: ~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment: this blank line should be removed (but we can do that while merging)

@xabbuh xabbuh added this to the 2.7 milestone Jan 28, 2018
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this looks like a bug or a poor DX in DoctrineBundle. Table charset/collate should be the same as the one configured in the database ... unless you configure the table options explicitly. But maybe I'm missing something here.

@xabbuh
Copy link
Member

xabbuh commented Jan 28, 2018

For the records, there is a related issues in the DoctrineBundle repo (see doctrine/DoctrineBundle#766).

my doctrine.yml had a ```charset: utf8mb4``` but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the database
@javiereguiluz
Copy link
Member

@tvlooy thanks for this nice little tip. I hope DoctrineBundle fixes it in the future and this is no longer needed. By the way, we merged this in 2.7 branch.

javiereguiluz added a commit that referenced this pull request Jan 29, 2018
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9141).

Discussion
----------

Update doctrine.rst

my doctrine.yml had a ```charset: utf8mb4``` but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the database

Commits
-------

81f9051 Update doctrine.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants