Revert asset versioning back to SF 3 directory structure #9155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allejo thanks for fixing this. You are right because we use the new dir structure starting from 4.0 version, so we must revert this for 3.x versions |
javiereguiluz
added a commit
that referenced
this pull request
Jan 28, 2018
…(allejo) This PR was merged into the 3.3 branch. Discussion ---------- Revert asset versioning back to SF 3 directory structure I don't believe SF 3 started using the `public/` directory, right? I think the 3.x docs were updated a bit prematurely since the 3.4 docs are affected too. Should the 3.4 change be another PR or could that be cherry-picked by a maintainer? Commits ------- 8c37957 Revert back to SF 3 directory structure
|
About the 3.4 branch, don't worry because we "merge up" all changes of all branches ... so this will land on 3.4 branch today or tomorrow. Thanks! |
xabbuh
added a commit
that referenced
this pull request
Jan 28, 2018
|
reverted on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe SF 3 started using the
public/directory, right? I think the 3.x docs were updated a bit prematurely since the 3.4 docs are affected too. Should the 3.4 change be another PR or could that be cherry-picked by a maintainer?