do never fetch private services from the container #9157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explaining that private services can still be fetched from the container under certain circumstances does not look like a good idea. Not only is it hard to grasp for beginners to understand why this sometimes works. It also becomes a real problem when upgrading to Symfony 4 where all private services won't be retrievable from the container through service location.
javiereguiluz
approved these changes
Jan 28, 2018
| @@ -57,12 +57,11 @@ What makes private services special is that, if they are only injected once, | |||
| they are converted from services to inlined instantiations (e.g. ``new PrivateThing()``). | |||
| This increases the container's performance. | |||
|
|
|||
| Now that the service is private, you *should not* fetch the service directly | |||
| Now that the service is private, you *must not* fetch the service directly | |||
There was a problem hiding this comment.
Ideally I'd like to say: "you can't fetch..." but since you can or cannot depending on some other circumstances, I guess your reword is the best we can do for now.
|
Thanks Christian. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 29, 2018
This PR was merged into the 2.7 branch. Discussion ---------- do never fetch private services from the container Explaining that private services can still be fetched from the container under certain circumstances does not look like a good idea. Not only is it hard to grasp for beginners to understand why this sometimes works. It also becomes a real problem when upgrading to Symfony 4 where all private services won't be retrievable from the container through service location. Commits ------- fedc522 do never fetch private services from the container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explaining that private services can still be fetched from the container
under certain circumstances does not look like a good idea. Not only is
it hard to grasp for beginners to understand why this sometimes works.
It also becomes a real problem when upgrading to Symfony 4 where all
private services won't be retrievable from the container through service
location.