[FrameworkBundle] feature: redirect query params too in RedirectController #9314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
the
Waiting Code Merge
xabbuh
reviewed
Apr 20, 2018
routing/redirect_in_config.rst
Outdated
| @@ -155,3 +158,4 @@ action: | |||
| Because you are redirecting to a route instead of a path, the required | |||
| option is called ``route`` in the ``redirect()`` action, instead of ``path`` | |||
| in the ``urlRedirect()`` action. | |||
|
|
|||
routing/redirect_in_config.rst
Outdated
| @@ -146,6 +148,7 @@ action: | |||
| '_controller' => 'Symfony\Bundle\FrameworkBundle\Controller\RedirectController::redirectAction', | |||
| 'route' => 'sonata_admin_dashboard', | |||
| 'permanent' => true, | |||
| 'keepQueryParams' => true | |||
There was a problem hiding this comment.
The trailing comma in the last element of the arrays is missing, look #8325
Adding documentation for the redirectAction improvement
|
@xabbuh @DylanDelobel done |
xabbuh
reviewed
Apr 25, 2018
routing/redirect_in_config.rst
Outdated
| @@ -96,7 +96,7 @@ Redirecting Using a Route | |||
|
|
|||
| Assume you are migrating your website from WordPress to Symfony, you want to | |||
| redirect ``/wp-admin`` to the route ``sonata_admin_dashboard``. You don't know | |||
| the path, only the route name. This can be achieved using the | |||
| the path, only the route name, if you pass query parameters to this route and active the ``keepQueryParams``, it will be redirected too. This can be achieved using the | |||
There was a problem hiding this comment.
We usually split lines after the first word that crosses the 72nd character. But we can make that tweak while merging. :)
xabbuh
approved these changes
Apr 25, 2018
javiereguiluz
added
Status: Reviewed
Missing Documentation
and removed
Status: Needs Review
labels
|
Thanks for documenting this new 4.1 feature ... and for implementing the feature too! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 26, 2018
…edirectController (Simperfit, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] feature: redirect query params too in RedirectController Adding documentation for the redirectAction improvement. This needs the feature to be merged first Commits ------- ba5c343 Restored a removed character 6c92c05 Reworded the new option explanation 7210586 feature: redirect query params too in RedirectController
javiereguiluz
added a commit
that referenced
this pull request
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation for the redirectAction improvement.
This needs the feature to be merged first