Added a short section about registering commands #9408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Mar 9, 2018
| Symfony commands must be registered as services and :doc:`tagged </service_container/tags>` | ||
| with the ``console.command`` tag. If the PHP class of your command extends from | ||
| :class:`Symfony\\Component\\Console\\Command\\Command`, Symfony does this for | ||
| you automatically. |
There was a problem hiding this comment.
This doesn't look right to me. Commands do not need to be registered as services in Symfony 2.7 as they are auto-discovered. Additionally, these will not be tagged automatically by Symfony (autoconfiguration was added in 3.3).
There was a problem hiding this comment.
So, the conditions in 2.7 and 2.8 are: the command must be stored in Command/ dir, the class name must end in Command and they must extend the base Command class?
There was a problem hiding this comment.
Yes, and IIRC correctly we have a section somewhere in the docs that explains these steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #9403, I realized that we could add a short section explaining that commands must be registered (although Symfony does this for you most of the times). If we merge this, in 3.4 I'll change the description to mention the autoconfiguration instead of this, which is what #9403 fixed.