[VarDumper] Fix rendering of inline code #9605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is tricky. We did this on purpose because the Maybe we can fix this with a little reword: * A bit field of ``EXCLUDE_*`` constants from the
:class:`Symfony\\Component\\VarDumper\\Caster\\Caster` class. |
|
Oh I see. Yes we can do as you propose or keep as it is but removing some unwanted backquotes
See, there is twice 2 backquotes that prevent the rendering and complicate reading. We can just remove them. Tell me, what is the best, I will update the PR |
…ning of the First Example page (Lyrkan) This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes symfony#9526). Discussion ---------- [Encore] Don't enable the Sass loader at the beginning of the First Example page Someone pointed out in symfony/webpack-encore#287 that if you follow the [First example](http://symfony.com/doc/master/frontend/encore/simple-example.html) page from top to bottom you are going to run `yarn encore` before being informed that calling `enableSassLoader()` implies adding additional dependencies (which is done just after). ~~This PR moves the related paragraph to warn the user that Encore will tell him about missing packages before he encounters the error.~~ ~~I also added the "after running it" part to make it a bit more obvious that the information is going to be present in the command output.~~ **Edit:** Changed it so `enableSassLoader()` is commented before running Encore for the first time Commits ------- 18586e2 [Encore] Don't enable the Sass loader at the beginning of the First Example page
kevin-verschaeve
force-pushed
the
var-dumper/fix-code-rendering
branch
from
0d5bc47 to
15ef727
Compare
|
@javiereguiluz it seems that just adding a space fix the issue :) |
javiereguiluz
force-pushed
the
var-dumper/fix-code-rendering
branch
from
15ef727 to
8389469
Compare
boninir
approved these changes
Apr 16, 2018
|
I like your solution! Let's merge it (on 3.4 branch). Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 16, 2018
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #9605). Discussion ---------- [VarDumper] Fix rendering of inline code A small piece of code that is not rendered correctly on the varDumper component Commits ------- 8389469 [VarDumper] Fix rendering of inline code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small piece of code that is not rendered correctly on the varDumper component