Skip to content

little typo event_dispatcher.rst #9769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

little typo event_dispatcher.rst #9769

wants to merge 1 commit into from

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented May 14, 2018 •
edited
Loading

(also in the 4 line, not in 2)

@xabbuh
Copy link
Member

xabbuh commented May 14, 2018

Thank you for fixing this typo @SpacePossum. However, it looks like this is not present in any of the maintained branches (which are 2.7, 2.8, 3.4, 4.0, 4.1, and master). Thus, I unfortunately need to close here.

@xabbuh xabbuh closed this May 14, 2018
@SpacePossum
Copy link
Contributor Author

no worries @xabbuh , however @ https://symfony.com/doc/current/event_dispatcher.html this typo is still present

@SpacePossum
Copy link
Contributor Author

i.e. https://github.com/symfony/symfony-docs/edit/4.0/event_dispatcher.rst

@xabbuh xabbuh reopened this May 14, 2018
@xabbuh xabbuh added this to the 2.7 milestone May 14, 2018
@xabbuh
Copy link
Member

xabbuh commented May 14, 2018

Oh indeed, you are absolutely right. Sorry, I totally missed that . We'll merge it into the 2.7 branch.

@javiereguiluz
Copy link
Member

Thank you @SpacePossum.

javiereguiluz added a commit that referenced this pull request May 15, 2018
@javiereguiluz
minor #9769 little typo event_dispatcher.rst (SpacePossum)
7cd6cd2 
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #9769).

Discussion
----------

little typo event_dispatcher.rst

(also in the 4 line, not in 2)

Commits
-------

b98355f Update event_dispatcher.rst
@SpacePossum
Copy link
Contributor Author

thanks @ricknox , @xabbuh and @javiereguiluz 👍 :)

@SpacePossum SpacePossum deleted the patch-1 branch May 15, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@SpacePossum @xabbuh @javiereguiluz @carsonbot