Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

Fix sqlite db path in parameters.yml.dist #1055

Closed
wants to merge 1 commit into from

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 15, 2017

This should have been done in #1032. Adding the path to .gitignore was done on symfony-demo, I think we can do it here too.

.gitignore Outdated
@@ -5,6 +5,8 @@
!/var/cache
/var/cache/*
!var/cache/.gitkeep
!/var/data
/var/data/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var/data is already ignored by var/. What's the point of this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this only makes sense if we also commit a .gitkeep file inside var/data/.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, reverted

@chalasr chalasr changed the title Fix sqlite db path in parameters.yml.dist, ignore it Fix sqlite db path in parameters.yml.dist Mar 15, 2017
@fabpot
Copy link
Member

fabpot commented Mar 15, 2017

Merging into 3.2 instead.

@chalasr chalasr changed the base branch from 3.1 to 3.2 March 15, 2017 13:20
@chalasr
Copy link
Member Author

chalasr commented Mar 15, 2017

Rebased on 3.2.

@fabpot fabpot closed this Mar 15, 2017
@chalasr chalasr deleted the fix-sqlite-path branch March 15, 2017 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants