Skip to content

24773 deprecation of getrequestformat #25213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

24773 deprecation of getrequestformat #25213

wants to merge 5 commits into from

Conversation

mattwillo
Copy link

@mattwillo mattwillo commented Nov 29, 2017 •
edited
Loading

Q A
Branch? 4.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #24773
License MIT
Doc PR symfony/symfony-docs#...

@mattwillo mattwillo changed the base branch from master to 3.4 November 29, 2017 18:01
@mattwillo mattwillo mentioned this pull request Nov 29, 2017
Closed
@stof stof changed the base branch from 3.4 to master November 29, 2017 18:26
@stof
Copy link
Member

stof commented Nov 29, 2017

Given that stable release of Symfony 3.4 and 4.0 is tomorrow, this is far too late to add a new deprecation in it. So I changed the target to master

@stof stof added this to the 4.1 milestone Nov 29, 2017
@stof
Copy link
Member

stof commented Nov 29, 2017

referencing your own PR in fixed ticket does not make sense

stof
stof reviewed Nov 29, 2017
View reviewed changes
src/Symfony/Component/HttpFoundation/Request.php Outdated
@@ -196,7 +196,7 @@ class Request
/**
* @var string
*/
protected $format;
protected $requestedResponseFormat;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming a protected property is a BC break. This is not allowed. See https://symfony.com/doc/current/contributing/code/bc.html for details about which kind of changes are allowed or no to respect the BC policy.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert that.

@Jean85
Copy link
Contributor

Jean85 commented Nov 30, 2017

Status: needs work

@mattwillo
Copy link
Author

Updated above link, it was meant to point to the issue not my own PR, that was very strange.

Reverted rename of protected $format.

@mattwillo
Copy link
Author

Status: Needs review

@mattwillo
Copy link
Author

I am investigating the break on 7.2

@nicolas-grekas
Copy link
Member

I'm closing here as this didn't get much traction: renaming methods needs a clear benefit, so that the extra work we put on devs is justified. it doesn't feel the case here.
Thanks anyway for your PR, waiting the next one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

Assignees
No one assigned
Labels
BC Break Bug Deprecation Feature Status: Needs Review
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@mattwillo @stof @Jean85 @nicolas-grekas @carsonbot