Create HttpFoundation\Request->toObject() Function

[TheDevick]

Q	A
Branch?	6.2
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Feat #46864
License	MIT
Doc PR	symfony/symfony-docs#16941

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[FabienPapet]

I think return (object) $this->toArray() is the way to go as the try catch is not useful

[TheDevick]

I think return (object) $this->toArray() is the way to go as the try catch is not useful

So you mean remove the try and catch from the code?

[FabienPapet]

Yes, I think that you don't need to catch the exception from the toArray()

[ro0NL]

i'd prefer casting in userland (as always :))

[fabpot]

I agree that there is no need for this method to be part of core as the use case is very specific and not broad enough. Thank you for proposing.