[Validator] Improve Charset constraint message
#53256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 28, 2023
javiereguiluz
approved these changes
Dec 28, 2023
derrabus
approved these changes
Dec 28, 2023
|
Thank you Alexandre. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 29, 2023
…daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Add `Charset` french translation | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Following #53253. Would require #53253 (comment), which is in the pipe. Requires #53256 Commits ------- 7d6da4d [Validator] Add `Charset` french translation
nicolas-grekas
added a commit
that referenced
this pull request
Dec 29, 2023
…icolas-grekas) This PR was merged into the 7.1 branch. Discussion ---------- [Validator] Fix listing encodings in CharsetValidator | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Forgotten in #53256 Commits ------- 7e413ff [Validator] Fix listing encodings in CharsetValidator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a little discussion with @xabbuh, I think we found the final message 👍 This format is more consistent with existing ones like
File.