-
-
Notifications
You must be signed in to change notification settings - Fork 361
[Map] Add possibility to configure extra options #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
As this is serialized, I guess we should make some minimal type check on the content of extra, no ? cc @Kocal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra
is already used for Marker
and cie to let the developper pass extra data from the back to the front, but the difference with the actual system is that extra
are not used by UX Map, these extra
data are only used in ux:map:*
events.
Instead, I suggest you to implement rawOptions
on Map options front-side, nothing should be modified backend-side.
Thanks!
If we only change the front-side how can we set options in the backend which are passed to the front? We want to set some options to the map configuration based on configuration from Symfony DI. Example: for the vector layers we need to pass a layerName and apiKey. |
TODO
Related to #2445 (comment)
Usage: