Skip to content

Commit b063f51

Browse files
committed
bug #54 Re-adding window.jQuery to autoProvidejQuery (weaverryan)
This PR was merged into the master branch. Discussion ---------- Re-adding window.jQuery to autoProvidejQuery By adding `window.jQuery` to `autoProvidejQuery()`, it caused problems by making `window.jQuery = require('jquery')` not work (#32). But, *not* having it causes other obvious problems (see #52). This re-adds `window.jQuery` back. As a fix, we would document exposing jQuery as a global variable by doing this: ```js global.$ = global.jQuery = require('jquery'); ``` ping @alOneh Commits ------- 9653f1e re-adding window.jQuery to autoProvidejQuery
2 parents 5ca96e9 + 9653f1e commit b063f51

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/WebpackConfig.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ class WebpackConfig {
244244
this.autoProvideVariables({
245245
$: 'jquery',
246246
jQuery: 'jquery',
247+
'window.jQuery': 'jquery',
247248
});
248249
}
249250

0 commit comments

Comments
 (0)