Re-adding window.jQuery to autoProvidejQuery #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you mean jQuery should be exposed by doing this instead (as described in your comment in #32 (comment)): global.$ = global.jQuery = require('jquery'); |
|
Thanks @jdreesen - I copied the wrong version :). Updated my comment |
alOneh
approved these changes
Jun 25, 2017
stof
approved these changes
Jun 27, 2017
weaverryan
added a commit
that referenced
this pull request
Jun 28, 2017
This PR was merged into the master branch.
Discussion
----------
Re-adding window.jQuery to autoProvidejQuery
By adding `window.jQuery` to `autoProvidejQuery()`, it caused problems by making `window.jQuery = require('jquery')` not work (#32). But, *not* having it causes other obvious problems (see #52).
This re-adds `window.jQuery` back. As a fix, we would document exposing jQuery as a global variable by doing this:
```js
global.$ = global.jQuery = require('jquery');
```
ping @alOneh
Commits
-------
9653f1e re-adding window.jQuery to autoProvidejQuery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding
window.jQuerytoautoProvidejQuery(), it caused problems by makingwindow.jQuery = require('jquery')not work (#32). But, not having it causes other obvious problems (see #52).This re-adds
window.jQueryback. As a fix, we would document exposing jQuery as a global variable by doing this:ping @alOneh