Skip to content

Add TypeScript definitions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2020
Merged

Add TypeScript definitions #5

merged 2 commits into from
Apr 28, 2020

Conversation

remcohaszing
Copy link
Member

Dependencies have been bumped before adding types.

This adds a new dependency on @types/mdast.

@remcohaszing remcohaszing mentioned this pull request Apr 23, 2020
Merged
ChristianMurphy
ChristianMurphy approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @remcohaszing! 🙇

@ChristianMurphy
Copy link
Member

/cc @Rokt33r

@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🐢 platform/node This affects Node 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Apr 24, 2020
@ChristianMurphy ChristianMurphy requested a review from a team April 24, 2020 16:59
@Rokt33r
Copy link

Rokt33r commented Apr 26, 2020

LGTM!

@wooorm wooorm merged commit 8e28095 into syntax-tree:master Apr 28, 2020
@wooorm
Copy link
Member

wooorm commented Apr 28, 2020

Released in 3.0.0!

Btw, this was missing types and types in files in package.json, which while we all approved, were missing! 33329d2

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@Rokt33r Rokt33r Rokt33r approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🐢 platform/node This affects Node 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@remcohaszing @ChristianMurphy @Rokt33r @wooorm