Skip to content

Remove URL escaping in link labels #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2021
Merged

Remove URL escaping in link labels #2

merged 2 commits into from
Jan 4, 2021

Conversation

marcofranssen
Copy link
Contributor

@marcofranssen marcofranssen commented Jan 2, 2021 •
edited
Loading

@wooorm
Copy link
Member

wooorm commented Jan 2, 2021

Thanks for working on this! Could you also add tests?

@marcofranssen
Copy link
Contributor Author

marcofranssen commented Jan 4, 2021 •
edited
Loading

@wooorm added the testcase. It works. Could you let me know when remark-gfm gets a new release?

marcofranssen
marcofranssen commented Jan 4, 2021
View reviewed changes
test.js
{extensions: [autolinkLiterals.toMarkdown]}
),
`[http://localhost]: http://localhost "Open example on localhost"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing that still disturbes me a bit is the additional whiteline here, but that is not related to the current issue I resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s a good default but it’s configurable: https://github.com/syntax-tree/mdast-util-to-markdown#optionstightdefinitions

@wooorm wooorm changed the title Prevent escaping from link text Remove URL escaping in link labels Jan 4, 2021
@wooorm wooorm merged commit 07bf001 into syntax-tree:main Jan 4, 2021
@wooorm
Copy link
Member

wooorm commented Jan 4, 2021

Released! https://github.com/syntax-tree/mdast-util-gfm-autolink-literal/releases/tag/0.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link text are getting escaped like this http\://localhost
2 participants
@marcofranssen @wooorm