Improve generic types #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🤞 phase/open
wooorm
reviewed
May 2, 2022
complex-types.d.ts
Outdated
| @@ -0,0 +1,19 @@ | |||
| import type {Node, Parent} from 'unist' | |||
|
|
|||
| export type NodeOfTree< | |||
There was a problem hiding this comment.
Suggested change
| export type NodeOfTree< | |
| /** | |
| * Internal utility to collect all descendants of in `Tree`. | |
| * @see https://github.com/syntax-tree/unist-util-visit-parents/blob/18d36ad/complex-types.d.ts#L43 | |
| */ | |
| export type InclusiveDescendant< |
Perhaps good to reference where it comes from?
And, what do you think of that original name, InclusiveDescendant?
There was a problem hiding this comment.
I though NodeOfTree was more explicit, but I can change it
There was a problem hiding this comment.
I understand.
Several terms in unist and friends are also used in other places that deal with trees, including the DOM for example. Descendant and inclusive descendant stem from that.
Some more common terms: https://github.com/syntax-tree/unist#glossary
Co-authored-by: Titus <[email protected]>
wooorm
approved these changes
May 2, 2022
This comment has been minimized.
This comment has been minimized.
wooorm
added
🦋 type/enhancement
|
Released in 3.1.0! |
5 tasks
wooorm
pushed a commit
that referenced
this pull request
May 3, 2022
Related-to: GH-4. Closes Gh-5. Reviewed-by: Titus Wormer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Continuation of #3. This PR adds better types for
map()inspired by the types ofunist-util-visit-parents.