fix(3384): tailcall CLI command not recognized #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: fix
Anshgrover23
changed the title
Anshgrover23
changed the title
Anshgrover23
commented
May 28, 2025
| @@ -33,34 +33,34 @@ jobs: | |||
| ] | |||
| include: | |||
| - build: linux-x64-gnu | |||
| os: ubuntu-latest | |||
| os: ubuntu-22.04 | |||
| rust: stable | |||
There was a problem hiding this comment.
ubuntu 24 cause libc issues on older distro such as ubuntu 22
Anshgrover23
commented
May 28, 2025
| @@ -141,7 +141,7 @@ opentelemetry-appender-tracing = { version = "0.4.0" } | |||
| opentelemetry-prometheus = "0.16.0" | |||
| phonenumber = "0.3.4" | |||
| chrono = "0.4.38" | |||
| async-graphql-extension-apollo-tracing = { version = "3.2.15"} | |||
| async-graphql-extension-apollo-tracing = { git = "https://github.com/Anshgrover23/async_graphql_apollo_studio_extension", rev = "d89ea0588552c8eb10b7169c012ff3613970126c" } | |||
| headers = { workspace = true } | |||
There was a problem hiding this comment.
I have already done a PR upstream to fix the issue async-graphql/async_graphql_apollo_studio_extension#194
Anshgrover23
commented
May 28, 2025
| @@ -44,7 +44,8 @@ async function genPlatformPackage() { | |||
| cpu: [cpu], | |||
| } | |||
|
|
|||
| if (libc) platformPackage.libc = [libc] | |||
| // Only set libc for non-Windows platforms | |||
| if (libc && os !== 'win32') platformPackage.libc = [libc] | |||
|
|
|||
There was a problem hiding this comment.
@tusharmath ,
npm only set libc on non-windows platforms
on windows , libc = undefined
|
Hey @tusharmath, just a quick follow-up—could you please take a look at my PR when you get a moment? |
|
Action required: PR inactive for 5 days. |
github-actions
bot
added
the
state: inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fix: tailcall CLI command not recognized
Issue Reference(s):
Fixes #3384
/claim #3384
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>