Skip to content

Show source diagnostics when imports contain a layer #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

Show source diagnostics when imports contain a layer #1204

merged 2 commits into from
Feb 13, 2025

Conversation

thecrypticace
Copy link
Contributor

Fixes #1099

@thecrypticace thecrypticace marked this pull request as ready for review February 13, 2025 15:34
philipp-spiess
philipp-spiess approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@thecrypticace thecrypticace merged commit 34fb4b5 into main Feb 13, 2025
@thecrypticace thecrypticace deleted the fix/source-layer branch February 13, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@RobinMalfait RobinMalfait Awaiting requested review from RobinMalfait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diagnostics are not accurate when @imports contain layer(…)
2 participants
@thecrypticace @philipp-spiess