Skip to content

Remove buggy await tw.init(); call #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

atgote
Copy link
Contributor

@atgote atgote commented Jun 19, 2023

This is to resolve issue #802

  • Removed call await tw.init() which led to improper initialization communication while LSP client does't support dynamic registration
  • Removed unnecessary parameter connection and check for connection.onInitialized inside the supportsDynamicRegistration() method

@happysalada
Copy link

@bradlc sorry to ping you directly. This PR fixes an issue that prevents usage in the helix editor. Its not a major editor, but it would be amazing to have this merged.

@bradlc
Copy link
Contributor

bradlc commented Aug 22, 2023

Hey @atgote, thanks for investigating the issue and opening this PR! I hope you don't mind I updated the PR slightly to avoid "unhandled method" errors.

Going to merge this, and then a new insiders version of @tailwindcss/language-server will automatically be published shortly afterwards (npm i @tailwindcss/language-server@insiders)

If you spot any other issues please let me know 👍

@bradlc bradlc merged commit d5268fd into tailwindlabs:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants