Improve bundle size by replacing detective-typescript
#10825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/improve-detective-bundle-size
branch
3 times, most recently
from
2c3a362 to
eb3ea1f
Compare
We are not parsing the code but just trying to pluck out the dependencies used via `import` and `require`.
RobinMalfait
force-pushed
the
feat/improve-detective-bundle-size
branch
from
eb3ea1f to
dc82d33
Compare
RobinMalfait
force-pushed
the
feat/improve-detective-bundle-size
branch
from
dc82d33 to
f3684b5
Compare
This won't be the prettiest if it happens, but at least we are not swallowing errors which should make bugs be easier to discover. See previous commit for an example... 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the bundle size by replacing
detective-typescript.detective-typescriptshipstypescriptas a dependency which means that the bundle size went up by at least ~65MB.Thank you @bradlc for noticing this!