Skip to content

Bool values in options are not unwrapped #18

Closed
@kirill-kruchkov

Description

@kirill-kruchkov

Hello!

If I pass visitor.shouldPersist = false (for setVisitorInfo) or options.emailNotRequired = false (e.g., for startChat) from JS this options[@"shouldPersist"] || NO resolves to YES when NO is expected.

To fix that we should unwrap bool value like that: [options[@"shouldPersist"] boolValue] || NO.

Got a PR to submit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions