Feature/agents online #110
Conversation
ios/RNZendeskChatModule.m
Outdated
| (RCTPromiseResolveBlock) resolve | ||
| rejecter: (RCTPromiseRejectBlock) reject) { | ||
|
|
||
| [ZDKChat.accountProvider getAccout:^(ZDKChatAccount *account, NSError *error) { |
There was a problem hiding this comment.
yes, looks like it is
gabrielperales
force-pushed
the
feature/agentsOnline
branch
from
034660d to
1409b17
Compare
|
@fbartho Tested on iOS and it works :) |
| rejecter: (RCTPromiseRejectBlock) reject) { | ||
|
|
||
| [ZDKChat.accountProvider getAccount:^(ZDKChatAccount *account, NSError *error) { | ||
| if (account) { |
There was a problem hiding this comment.
If there is no account, this promise never resolves.
I'm going to add a code-snippet to reject in that situation.
| @@ -377,4 +378,29 @@ public void update(ChatState chatState) { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| @ReactMethod | |||
| public void areAgentsOnline(Promise promise) { | |||
There was a problem hiding this comment.
No import for Promise, resulting in compliation error in android, Please fix it, you cant use Promise
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh! Maybe it’s not. I’ll take a look tomorrow. We had some build issues due to jitpack.io being offline yesterday.
There was a problem hiding this comment.
yes its not and after npm install 0.4.1-beta.8 is getting installed and causing build error, you need to fix this, in a new PR
There was a problem hiding this comment.
Active fixes for 0.4.1 can be found in #85 -- 0.4.1-beta.9 is published and now building in our CI. If further fixes are needed, I'll publish more betas until it seems ready.
There was a problem hiding this comment.
Beta.9 passed compilation, so I'm shipping 0.4.1! -- If you find bugs, please report them.
No description provided.