Skip to content

Add init method for iOS #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

Add init method for iOS #42

merged 1 commit into from
Jan 31, 2020

Conversation

zanechua
Copy link
Contributor

@zanechua zanechua commented Jan 30, 2020 •
edited
Loading

Allows you to initialise the zendesk backend via runtime

fbartho
fbartho approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I thought about doing the same when I initially set up this package in a new app.

@fbartho fbartho added this to the 0.3.0: RN 0.62 Support milestone Jan 30, 2020
@fbartho fbartho mentioned this pull request Jan 30, 2020
Closed
@fbartho
Copy link
Contributor

fbartho commented Jan 30, 2020

Instead of only doing an init with a string, maybe we should do an options hash?

@zanechua
Copy link
Contributor Author

If we refactor to use options, we have to take into consideration that changes need to be made to the init method for Android too! If we can find a way to use options inside the Java code for android then we will be able to resolve the prechat form PR also.

@fbartho fbartho mentioned this pull request Jan 30, 2020
Closed
@robertmurray robertmurray merged commit 95d1074 into taskrabbit:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbartho fbartho fbartho approved these changes

Assignees

@fbartho fbartho

@robertmurray robertmurray

Labels
None yet
Projects
None yet
Milestone
0.3.0: RN 0.62 Support
Development

Successfully merging this pull request may close these issues.
3 participants
@zanechua @fbartho @robertmurray