Skip to content

Update build.gradle and add prechat form #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Update build.gradle and add prechat form #43

merged 1 commit into from
Jan 31, 2020

Conversation

zanechua
Copy link
Contributor

@zanechua zanechua commented Jan 30, 2020

Updated build.gradle to conform with the latest zendesk android sdk.

Added a prechat-form for android to define a more consistent experience for both iOS and Android.

Only issue now is I've hard-coded the requirements for the prechat-form. I did have a initial look into how i could define the same options in iOS to make certain fields optional but did not have the time to follow through on that.

@fbartho
Copy link
Contributor

fbartho commented Jan 30, 2020

I love the gradle updates, we hadn’t looked at that yet!

I’m however uncomfortable requiring the PreChat form unless we can configure it, and potentially change the requirements. Is this feature only available on Android?

@fbartho fbartho added this to the 0.3.0: RN 0.62 Support milestone Jan 30, 2020
@zanechua
Copy link
Contributor Author

The feature is available in both android and iOS. In the current code, iOS already has the code for the prechat-form at https://github.com/taskrabbit/react-native-zendesk-chat/blob/master/ios/RNZendeskChatModule.m#L42 . I had to add this in as we do use the prechat-form for zendesk and it would be confusing to have different experiences across platforms.

I'll see if I can find a way to define the options so that we have unified options for both platforms but no promises at the moment.

@fbartho
Copy link
Contributor

fbartho commented Jan 30, 2020

Good catch! Please forgive my unfamiliarity with this codebase and Android. I just assumed that that was a built-in difference between the underlying SDKs!

@zanechua
Copy link
Contributor Author

No worries. Just want to see the changes merged in so I don't have to maintain a scoped fork of this. 😄

@robertmurray robertmurray merged commit 1931f05 into taskrabbit:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants