Fix android visitor info #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, tomorrow morning 👌 |
|
@padupuy bumping this if you're still interested! |
padupuy
force-pushed
the
fix/android-visitor-info
branch
from
c86a976 to
7788cb7
Compare
padupuy
changed the title
|
@fbartho sorry for the delay, the PR is now sync with the main branch |
This was referenced Oct 28, 2020
|
This code is available with other changes in https://www.npmjs.com/package/react-native-zendesk-chat/v/0.4.1-beta.4 |
|
@fbartho the 0.4.1-beta.4 is OK for me on Android and iOS 👌 |
|
This has been merged into the release branch, and shipped in https://www.npmjs.com/package/react-native-zendesk-chat/v/0.4.1-beta.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this strange comment on the offical Zendesk Forum and this support post, there is an additionnal config to enable visitor info to be shown on the zendesk dashboard.
Also, bump android zendesk dependencies and add zendeskAppId to the init method to match the last Zendesk Chat SDK v2 documentation.