Skip to content

Use uv to set python version in README instructions #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Use uv to set python version in README instructions #811

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f612227
Check that intended python version is being used
dandavison Mar 31, 2025
47b28be
Don't use setup-python action
dandavison Mar 31, 2025
0778ee8
Deliberate error
dandavison Mar 31, 2025
ad7e7a5
Install python on $PATH in addition to in virtualenv
dandavison Mar 31, 2025
4543376
Revert "Don't use setup-python action"
dandavison Mar 31, 2025
c088cc2
Don't use uv --preview to install
dandavison Mar 31, 2025
5537499
Revert "Deliberate error"
dandavison Mar 31, 2025
87a747c
Specify python version with `uv sync`
dandavison Mar 31, 2025
90923ea
partial revert
dandavison Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,7 +1544,7 @@ poe test -s --log-cli-level=DEBUG -k test_sync_activity_thread_cancel_caught
#### Proto Generation and Testing

To allow for backwards compatibility, protobuf code is generated on the 3.x series of the protobuf library. To generate
protobuf code, you must be on Python <= 3.10, and then run `uv add "protobuf<4"` + `uv sync --all-extras`. Then the
protobuf code, run `uv add "protobuf<4" --python 3.10` + `uv sync --all-extras --python 3.10`. Then the
protobuf files can be generated via `poe gen-protos`. Tests can be run for protobuf version 3 by setting the
`TEMPORAL_TEST_PROTO3` env var to `1` prior to running tests.

Expand Down
Loading