Skip to content

fix: pin aria-query #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

MatanBobi
Copy link
Member

@MatanBobi MatanBobi commented Jun 14, 2023

What: Temporarily pinning aria-query to version 5.1.3.

Why: The new version of aria-query(5.2.1) was released yesterday and caused a few issues on our end.
Affected issues:
Fixes #1235
Fixes #1238

How: Pinning the version in package.json.

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

@MatanBobi MatanBobi requested a review from eps1lon June 14, 2023 13:10
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b1c1dd0:

Sandbox Source
react-testing-library-examples Configuration

@MatanBobi MatanBobi requested a review from timdeschryver June 14, 2023 13:18
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #1237 (b1c1dd0) into main (d09b3c2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1237   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1038      1038           
  Branches       346       349    +3     
=========================================
  Hits          1038      1038           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eps1lon eps1lon merged commit 491e930 into testing-library:main Jun 14, 2023
@wojtekmaj
Copy link

wojtekmaj commented Sep 25, 2023

Please note that by pinning the package, an update to aria-query, replacing bloated deep-equal dependency with a much smaller alternative dequal, cannot be used. It would be beneficial for the project to fix the issues mentioned in the first comment in aria-query if possible.

@MatanBobi
Copy link
Member Author

Hi @wojtekmaj :) We're working on upgrading aria-query in our next major, afair, it's already merged in the alpha branch.

@ogonkov ogonkov mentioned this pull request Dec 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants