-
Notifications
You must be signed in to change notification settings - Fork 470
chore: Bump jsdom to 15 #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5390825:
|
}, | ||
] | ||
`) | ||
await expect(promise).resolves.toMatchSnapshot() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes
Jest: Multiple inline snapshots for the same call are not supported.
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 22 22
Lines 385 385
Branches 91 91
=====================================
Hits 385 385 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the snapshots are pretty much useless now. We'll need these tests to be rewritten to make sure they're testing what they should be. Maybe by making more explicit assertions on the mutation record.
@kentcdodds Will do. I didn't look closely what the purpose of the test was. Should we leverage custom snapshot serializers or serialize them directly in the test? |
462e2a5
to
5390825
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
🎉 This PR is included in version 6.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Not sure which version we should use. While the latest is 16 it isn't the default version used in jest. Ideally we would test with jsdom 15 and 16 just to be aware of changes between those versions.
What:
Bump used jsdom version to 15.2.1
Why:
jsdom 15 has MutationObserver support as well as perf improvements.
How:
Checklist:
docs site
DefinitelyTyped