Skip to content

chore: remove outdated code comments #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 23, 2020

Resolves #664 (comment)

What:

No code changes

Why:

#664 reatained some outdated code comments that were made obsolete with that PR

How:

Remove comments

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97d62a8:

Sandbox Source
brave-hofstadter-j6xgh Configuration

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #665 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #665   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          583       583           
  Branches       149       149           
=========================================
  Hits           583       583           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a3212...97d62a8. Read the comment docs.

@eps1lon eps1lon requested a review from afontcu June 23, 2020 08:09
@eps1lon eps1lon merged commit 260e1e8 into testing-library:master Jun 23, 2020
@eps1lon eps1lon deleted the chore/comments branch June 23, 2020 08:30
@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants