Skip to content

chore: Don't test with node 10 or 15 #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nickserv
Copy link
Member

What: Don't test with node 10 or 15

Why: Node 10 and 15 reached EOL so let's free up some CI resources.

How: Remove 10 and 15 from node test matrix.

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 239d848:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #975 (239d848) into main (56a4c75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #975   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          966       966           
  Branches       298       298           
=========================================
  Hits           966       966           
Flag Coverage Δ
node-10.14.2 ?
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-15 ?
node-16 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a4c75...239d848. Read the comment docs.

@MatanBobi
Copy link
Member

I'm not 100% familiar with the approach but should we bump a major version stating that from now on we don't support Node 10 and 15?

@eps1lon
Copy link
Member

eps1lon commented Jun 12, 2021

I'm not 100% familiar with the approach but should we bump a major version stating that from now on we don't support Node 10 and 15?

Let's just drop node 10 support in this PR as well i.e. close #957 and target the alpha branch

@eps1lon eps1lon mentioned this pull request Jun 12, 2021
2 tasks
@eps1lon
Copy link
Member

eps1lon commented Jun 12, 2021

Closed in #976

@eps1lon eps1lon closed this Jun 12, 2021
@MichaelDeBoey MichaelDeBoey deleted the nickmccurdy-patch-1 branch June 12, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants