Skip to content

chore: migrate master to main by renaming master to main in all refer… #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2021

Conversation

marianna-exelate
Copy link
Contributor

What:

Changed the refs from the 'master' branch into 'main'

Why:

To be more compliment with updated web standards

How:

updated mainly the contribution guide and the validation file, kept 'master' branch available to be backward compatible as an intermediate phase

Checklist:

  • [ x] Documentation updated
  • [ x] Tests
  • [ x] Ready to be merged
  • [ x] Added myself to contributors table

@mpeyper
Copy link
Member

mpeyper commented May 5, 2021

Hi @marianna-exelate, thanks for this! It's been on my to-do list for a while.

Other than the references in the repo to master, do you know of any other steps that need to be taken (e.g. changing the default branch in the repo settings)?

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #612 (3f40c37) into main (3b719d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #612   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          218       218           
  Branches        28        26    -2     
=========================================
  Hits           218       218           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b719d1...3f40c37. Read the comment docs.

@@ -529,6 +529,15 @@
"bug",
"code"
]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done automatically with a bot, you can remove this :)

@MatanBobi
Copy link
Member

Hi @marianna-exelate, thanks for this! It's been on my to-do list for a while.

Other than the references in the repo to master, do you know of any other steps that need to be taken (e.g. changing the default branch in the repo settings)?

I can help with that @mpeyper, we've done it in rtl already :) Let me merge this one and verify everything works, I'll do it later on today

@mpeyper
Copy link
Member

mpeyper commented May 5, 2021

Thanks @MatanBobi, it's late here so won't get to it myself for a while.

@MatanBobi MatanBobi merged commit de46fc0 into testing-library:main May 5, 2021
@MatanBobi
Copy link
Member

Thanks @marianna-exelate! :)

@MatanBobi
Copy link
Member

@all-contributors please add @marianna-exelate for infra :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @marianna-exelate! 🎉

@github-actions
Copy link

🎉 This PR is included in version 5.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants