Skip to content

chore: center the docs links #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2018
Merged

chore: center the docs links #257

merged 1 commit into from
Dec 31, 2018

Conversation

alexkrolick
Copy link
Collaborator

@alexkrolick alexkrolick commented Dec 31, 2018

πŸ€·β€β™‚οΈ

What:

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #257   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          27     27           
  Branches        5      5           
=====================================
  Hits           27     27

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 039c299...9fe7669. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool πŸ‘

@kentcdodds kentcdodds merged commit 95bc9b6 into master Dec 31, 2018
@kentcdodds kentcdodds deleted the alexkrolick-patch-1 branch December 31, 2018 19:49
@weyert
Copy link
Contributor

weyert commented Dec 31, 2018

Any reason why this has to be removed from the README file? Now you can't refer to the docs while not having internet e.g. on the airplane :(

@alexkrolick
Copy link
Collaborator Author

It's hard to keep in sync in two places - the rtl and dtl docs are already out of sync

You can pull down the repo for the docs if you'd like - it's all markdown

@kentcdodds
Copy link
Member

We should see what it would take to get the docs on https://devdocs.io and https://kapeli.com/dash and I wonder how hard it would be to make a service worker for the website πŸ€”

@alexkrolick
Copy link
Collaborator Author

https://docusaurus.io/blog/2018/09/11/Towards-Docusaurus-2

Maybe in Docusaurus 2.0

Opening this discussion on the docs repo

@weyert
Copy link
Contributor

weyert commented Jan 1, 2019

Never meant to sound negative just wanted to raise an accessibility issue πŸ˜‡
Trying to synchronise both projects using the Dino definitely makes totally sense :)

@kentcdodds
Copy link
Member

πŸŽ‰ This PR is included in version 5.4.3 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants