docs: Add window.localStorage.remove('token') statement to afterEach() in tests/login.js file #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) in __tests__/login.js file Due to the first test suite, I need to remove the token value generated from local storage. The second test suite will fail if the token value is not removed.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a03ab41:
|
2dubbing
changed the title
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 100 100
Branches 16 16
=========================================
Hits 100 100 Continue to review full report at Codecov.
|
|
@all-contributors please add @2dubbing for docs |
|
I've put up a pull request to add @2dubbing! 🎉 |
|
🎉 This PR is included in version 10.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
You need to add window.localStorage.removeItem('token') to afterEach() within 'tests/login.js' file in Complex Example in README.md file.
Why:
The token value exists in localstorage due to the first test suite. This causes the second test suite to fail.
How:
Adding window.localStorage.removeItem('token') code to the afterEach() callback function argument solved the problem.
Checklist:
docs site