Skip to content

docs: Link to new Discord #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2020
Merged

docs: Link to new Discord #507

merged 3 commits into from
Jun 22, 2020

Conversation

nickserv
Copy link
Member

No description provided.

@nickserv
Copy link
Member Author

I've removed most of Spectrum links, but I'm running into a layout issue involving the support links in Docusaurus, which I'm not very experienced with. When removing a link, the two rows no longer have three items each, and I get this unnatural layout where the second row is different.
image

One thing I've noticed is that we're giving more than three items to <GridBlock layout="threeColumn" align="left" />, which is only supposed to take three. However, even if I split this into two GridBlocks, I can't seem to get the second row to be left aligned.

@kentcdodds
Copy link
Member

I'm not sure 😬

@nickserv
Copy link
Member Author

nickserv commented Jun 21, 2020

@alexkrolick Would you mind taking a look at this issue if you have time?

Alternatively, I'd be ok with leaving the Spectrum link on the help page until we figure this out, as long as @kentcdodds is ok with it.

@nickserv nickserv changed the title Link to new Discord docs: Link to new Discord Jun 21, 2020
@kentcdodds
Copy link
Member

Meh, let's just merge it. We can fix it later.

@kentcdodds kentcdodds merged commit a21702b into master Jun 22, 2020
@kentcdodds kentcdodds deleted the link-to-new-discord branch June 22, 2020 13:24
@alexkrolick
Copy link
Collaborator

alexkrolick commented Jun 22, 2020

@nickmccurdy sorry I missed this.

Yeah, I think we got lucky with the layout aligning in the right number of columns. I recall trying a few different combos (like center-alignining different things, and different column counts) but the layout never really looked that great. Feel free to change it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants