v2.3.0 changes addressing issue 27 #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option must now go inside `HtmlWebpackInlineSVGPlugin({})` instead of `HtmlWebpackPlugin({})`. An error in console is written at build time otherwise.
* The defaults for the `svgo` module aren't hardcoded anymore and –excepting the `cleanupIDs` option– the defaults are now set by the own module `svgo` and not `html-webpack-inline-svg-plugin`.
Tests not added yet
|
Merging PR. 🤜 Comments still welcome. |
|
@theGC does the package get released on npm automatically? Or do you have to press the button manually? |
|
it auto publishes to npm, looks like v2.3.0 is live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address issue #27:
svgoConfigoption must now go insideHtmlWebpackInlineSVGPlugin({})instead ofHtmlWebpackPlugin({}). An error is thrown at webpack build time otherwise.svgomodule aren't hardcoded anymore and –excepting thecleanupIDsoption– the defaults are now set by the own modulesvgoand not byhtml-webpack-inline-svg-plugin.package.jsondependencies have been updated to latest versions.README.md.