Fix module deployment #6869
Fix module deployment #6869
Conversation
🦋 Changeset detectedLatest commit: 880650d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6869 +/- ##
=======================================
Coverage 55.21% 55.22%
=======================================
Files 896 896
Lines 57040 57042 +2
Branches 3952 3952
=======================================
+ Hits 31497 31499 +2
- Misses 25446 25447 +1
+ Partials 97 96 -1
🚀 New features to boost your workflow:
|
apps/dashboard/src/components/contract-components/fetchPublishedContractsFromDeploy.ts
Outdated
Show resolved
Hide resolved
apps/dashboard/src/components/contract-components/fetchPublishedContractsFromDeploy.ts
Outdated
Show resolved
Hide resolved
apps/dashboard/src/components/contract-components/fetchPublishedContractsFromDeploy.ts
Outdated
Show resolved
Hide resolved
| }); | ||
| publishURIs = [published.publishMetadataUri]; | ||
| } | ||
| } catch {} |
There was a problem hiding this comment.
do we want to log an error here?
also what happens if this fails, but the code continues? is it just gonna fail down the line?
There was a problem hiding this comment.
Yeah this is a fallback, but we don't need to throw here.
There was a problem hiding this comment.
It's something I added in case there's a contract-id we can search on thirdweb published contracts. Else, continue as before.
There was a problem hiding this comment.
We'll need to update ContractPublisher contract to map multiple metadata-uris (if present) for a single publish version. That's the best way to handle it. Added this in comments.
kumaryash90
added
the
merge-queue
Merge activity
|
- Handle refs and metadata format (solc vs zksolc) for modules
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on fixing module deployment issues in the `thirdweb` package, particularly with references and zk (zero-knowledge) support. It modifies contract deployment utilities and enhances the fetching of published contracts.
### Detailed summary
- Updated the `getOrDeployInfraContractFromMetadata` function to simplify contract retrieval.
- Changed the deployment logic to use `deployContractfromDeployMetadata`.
- Enhanced `fetchPublishedContractsFromDeploy` to handle zkSync chains and fetch metadata appropriately.
- Added new types and improved error handling for contract metadata fetching.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
yash/fix-module-deployment
branch
from
1f32b46 to
880650d
Compare
graphite-app
bot
removed
the
merge-queue
PR-Codex overview
This PR focuses on fixing module deployment issues related to references and zero-knowledge (zk) technology in the
thirdwebpackage.Detailed summary
getOrDeployInfraContractFromMetadatato improve deployment logic.deployContractfromDeployMetadata.fetchPublishedContractsFromDeployto handle zkSync chain variants and fetch metadata correctly.