Skip to content

[SDK] Handle fixed size arrays in solidity inputs #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 27, 2025

Fixes TOOL-4270


PR-Codex overview

This PR focuses on enhancing the handling of fixed-size arrays in Solidity inputs within the application, ensuring correct validation and parsing of Solidity types.

Detailed summary

  • Updated the condition for checking array types in solidity-inputs/index.tsx to end with ].
  • Modified the type check for parameters in parse-abi-params.ts to also end with ].
  • Adjusted validation logic in helpers.ts to ensure it only validates integers and unsigned integers if they do not end with ].

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 1:57am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 1:57am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 1:57am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 1:57am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 1:57am

Copy link

changeset-bot bot commented Apr 27, 2025

🦋 Changeset detected

Latest commit: 560e005

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK labels Apr 27, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title Handle fixed size arrays in solidity inputs [SDK] Handle fixed size arrays in solidity inputs Apr 27, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review April 27, 2025 22:08
@joaquim-verges joaquim-verges requested review from a team as code owners April 27, 2025 22:08
Copy link

linear bot commented Apr 27, 2025

Copy link
Contributor

github-actions bot commented Apr 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.19 KB (0%) 1.1 s (0%) 165 ms (+172.39% 🔺) 1.2 s
thirdweb (cjs) 143.86 KB (0%) 2.9 s (0%) 277 ms (+43.66% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 43 ms (+927.12% 🔺) 156 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 14 ms (+530.63% 🔺) 24 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 31 ms (+110.41% 🔺) 419 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant