Skip to content

Commit 7e51849

Browse files
Do not use RStudio Package Manager for R-devel (#4242)
* Do not use RStudio Package Manager for R-devel * Skip test when xml2 is not available * Remove workaround for systemfonts
1 parent 8aead50 commit 7e51849

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.github/workflows/R-CMD-check.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ name: R-CMD-check
1010

1111
# Increment this version when we want to clear cache
1212
env:
13-
cache-version: v3
13+
cache-version: v4
1414

1515
jobs:
1616
R-CMD-check:
@@ -24,7 +24,7 @@ jobs:
2424
config:
2525
- {os: windows-latest, r: '4.0', vdiffr: true, xref: true}
2626
- {os: macOS-latest, r: '4.0', vdiffr: true, xref: true}
27-
- {os: ubuntu-16.04, r: 'devel', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest", http-user-agent: "R/4.0.0 (ubuntu-16.04) R (4.0.0 x86_64-pc-linux-gnu x86_64 linux-gnu) on GitHub Actions"}
27+
- {os: ubuntu-16.04, r: 'devel', vdiffr: false, xref: true}
2828
- {os: ubuntu-16.04, r: '4.0', vdiffr: true, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
2929
- {os: ubuntu-16.04, r: '3.6', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
3030
- {os: ubuntu-16.04, r: '3.5', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}

tests/testthat/test-ggsave.R

+1-3
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,7 @@ test_that("ggsave restores previous graphics device", {
2929
})
3030

3131
test_that("ggsave uses theme background as image background", {
32-
# FIXME: This should check svglite, but, at the time of writing this, there's already a binary
33-
# package of svglite, and it can be installed even if the dependency is not available, surprisingly...
34-
skip_if_not_installed("systemfonts")
32+
skip_if_not_installed("xml2")
3533

3634
path <- tempfile()
3735
on.exit(unlink(path))

0 commit comments

Comments
 (0)