Skip to content

Do not use RStudio Package Manager for R-devel #4242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Oct 15, 2020

All visual tests fail on R-devel with this error:

 > test_check("ggplot2")
── 1. Error: aesthetics are drawn correctly (@test-aes.r#160)  ─────────────────
Graphics API version mismatch
Backtrace:
 1. vdiffr::expect_doppelganger(...)
 2. vdiffr:::writer(fig, testcase, title)
 3. vdiffr:::svglite(file, user_fonts = get_aliases())
 4. vdiffr:::svglite_(...)

(https://github.com/tidyverse/ggplot2/pull/4227/checks?check_run_id=1239216870#step:10:132)

I tried clearing cache, but it still failed. I bet this is because some binary on RStudio package manager is outdated. This might be solved by just waiting for some package to get rebuilt, but it kept failing at least for this 2 weeks, so I think there's little hope. This pull request removes RStudio Package Manager on R-devel runner and clears cache.

This pull request adds these changes:

  • Stop using RStudio Public Package Manager on R-devel runner
  • Remove workaround for systemfonts package as it's available again
  • Add a workaround for xml2 (it seems not available on R 3.2)

@yutannihilation
Copy link
Member Author

Hmm, xml2 cannot be installed on R 3.2...?

@yutannihilation
Copy link
Member Author

This should be ready to merge now.

For the behaviour of RStudio Public Package Manager, I asked on RStudio Community:
https://community.rstudio.com/t/how-frequently-are-r-devel-binaries-rebuilt-on-rstudio-public-package-manager/84926

@yutannihilation
Copy link
Member Author

I got the answer.

RStudio Package Manager doesn't build binary packages for R-devel yet. I think the GitHub Actions workflows currently install R 4.0 binaries for R-devel on Linux, which is probably okay in most cases.
(https://community.rstudio.com/t/how-frequently-are-r-devel-binaries-rebuilt-on-rstudio-public-package-manager/84926/2)

Since this isn't okay in our case, sticking with source seems a right choice.

Copy link
Member

@karawoo karawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all your work keeping the gh actions workflows working

@karawoo karawoo merged commit 7e51849 into tidyverse:master Oct 22, 2020
@yutannihilation
Copy link
Member Author

Thanks!

Unfortunately, the master fails because, 4 days ago, the digest package increased the minimum required R version to 3.3... This time, we might need to consider dropping support for R 3.2. I'll file a new issue for this.

https://github.com/cran/digest/blame/d385e0ba04673903d026ac483da9e9a2f1f3f55c/DESCRIPTION#L23

@yutannihilation yutannihilation deleted the ci/dont-use-rstudio-package-manager-for-r-devel branch October 22, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants