unused factor levels are not omitted from the legend

[Oravishayrizi]

Hello, I came across an unexpected behavior of scale_shape_manual that is not dropping missing values from the legend.
Explicitly using the drop=TRUE argument didn't make any difference on version 3.3.5 (nor version 3.3.4).

In version 3.3.3 the plot drops unused levels. I couldn't find any relevant change in the changelog, I may have missed it, but perhaps it's a bug.

require(remotes)
remotes::install_version("ggplot2", version = "3.3.3", repos = "http://cran.us.r-project.org",quiet = TRUE)
library(ggplot2)

# Dict
irisColors <-
    setNames( c('red', 'forestgreen', 'blue'),
             levels(iris$Species)  )

irislabel <-
    setNames( c('A', 'B', 'C'),
              levels(iris$Species)  )

irisshape <-
    setNames( c(15, 16,17),
              levels(iris$Species) )

# 3.3.3 output

ggplot(data = iris[iris$Species!="virginica",],aes(x = Sepal.Length,y = Sepal.Width,color = Species,shape=Species)) +
    geom_point() +
    scale_color_manual(values = irisColors,labels=irislabel)+
    scale_shape_manual(values = irisshape,labels=irislabel) 
remove.packages("ggplot2")
rstudioapi::restartSession()

# 3.3.5 output
install.packages("ggplot2",quiet = TRUE)
library(ggplot2)

# Dict
irisColors <-
    setNames( c('red', 'forestgreen', 'blue'),
              levels(iris$Species)  )

irislabel <-
    setNames( c('A', 'B', 'C'),
              levels(iris$Species)  )

irisshape <-
    setNames( c(15, 16,17),
              levels(iris$Species) )

ggplot(data = iris[iris$Species!="virginica",],aes(x = Sepal.Length,y = Sepal.Width,color = Species,shape=Species)) +
    geom_point() +
    scale_color_manual(values = irisColors,labels=irislabel)+ # Also when I explicit state: drop=TRUE
    scale_shape_manual(values = irisshape,labels=irislabel) #

[yutannihilation]

Thanks for reporting. This is already fixed by #4619 in the dev version. Sorry for inconvenience until the next release.

library(ggplot2)
packageVersion("ggplot2")
#> [1] '3.3.5.9000'

# Dict
irisColors <-
    setNames( c('red', 'forestgreen', 'blue'),
              levels(iris$Species)  )

irislabel <-
    setNames( c('A', 'B', 'C'),
              levels(iris$Species)  )

irisshape <-
    setNames( c(15, 16,17),
              levels(iris$Species) )

ggplot(data = iris[iris$Species!="virginica",],aes(x = Sepal.Length,y = Sepal.Width,color = Species,shape=Species)) +
    geom_point() +
    scale_color_manual(values = irisColors,labels=irislabel)+ # Also when I explicit state: drop=TRUE
    scale_shape_manual(values = irisshape,labels=irislabel) #

^{Created on 2021-11-07 by the reprex package (v2.0.1)}